Skip to content

minor coverage change#621

Merged
AlexInLog merged 3 commits into
v2from
minor_coverage
Aug 22, 2024
Merged

minor coverage change#621
AlexInLog merged 3 commits into
v2from
minor_coverage

Conversation

@AlexInLog

@AlexInLog AlexInLog commented Aug 21, 2024 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features
    • Enhanced compile-time evaluation capabilities for certain functions, improving performance through early optimizations.
    • Improved coverage reporting process by consolidating test targets, allowing for more comprehensive analysis.
  • Bug Fixes
    • Adjusted function signatures to ensure proper evaluation contexts for better usability in compile-time scenarios.

@coderabbitai

coderabbitai Bot commented Aug 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
Walkthrough

Walkthrough

The recent changes introduce the consteval specifier to several functions within the rpp::details::observables and rpp::details::observers namespaces. This modification ensures that the functions deduce_disposable_strategy and deduce_updated_disposable_strategy are evaluated at compile-time, enhancing performance through potential compiler optimizations. Additionally, the coverage generation logic in the CMake configuration has been refined for better readability and maintainability, incorporating multiple test targets for comprehensive reporting.

Changes

Files Change Summary
src/rpp/rpp/observables/details/...
src/rpp/rpp/observers/details/...		 Functions deduce_disposable_strategy and deduce_updated_disposable_strategy modified from auto* to consteval auto* for compile-time evaluation.
cmake/coverage.cmake Coverage generation logic updated; introduced RPP_COVERAGE_TARGETS for improved clarity and included additional test targets in the coverage report.

Poem

🐰 In the land of code where bunnies roam,
Compile-time magic makes us feel at home.
With consteval we leap, so swift and spry,
Optimizing hops beneath the bright blue sky!
Functions now dance in the compiler's embrace,
A joyful tune in this coding race! 🎶

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai Bot reviewed Aug 21, 2024
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ff8d149 and 91a3897.

Files selected for processing (2)
  • src/rpp/rpp/observables/details/disposable_strategy.hpp (2 hunks)
  • src/rpp/rpp/observers/details/fwd.hpp (1 hunks)
Additional comments not posted (2)
src/rpp/rpp/observers/details/fwd.hpp (1)

73-73: LGTM! But verify the function usage in the codebase.

The addition of the consteval specifier is approved as it enhances compile-time evaluation.

However, ensure that all calls to deduce_disposable_strategy are compatible with compile-time evaluation.

Run the following script to verify the function usage:

Verification successful

Function Usage Verified: Compile-Time Compatibility Confirmed

The deduce_disposable_strategy function is used in contexts compatible with its consteval specifier, ensuring compile-time evaluation. No runtime calls were found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `deduce_disposable_strategy` are compatible with compile-time evaluation.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type cpp -A 5 $'deduce_disposable_strategy'

Length of output: 8691

Script:

#!/bin/bash
# Search for any direct calls to `deduce_disposable_strategy` that might not be compatible with `consteval`.
rg --type cpp -A 5 $'deduce_disposable_strategy('

Length of output: 155

Script:

#!/bin/bash
# Corrected search for any direct calls to `deduce_disposable_strategy` that might not be compatible with `consteval`.
rg --type cpp -A 5 'deduce_disposable_strategy('

Length of output: 155

Script:

#!/bin/bash
# Corrected search with escaped parentheses for any direct calls to `deduce_disposable_strategy` that might not be compatible with `consteval`.
rg --type cpp -A 5 'deduce_disposable_strategy\('

Length of output: 1253

src/rpp/rpp/observables/details/disposable_strategy.hpp (1)

82-82: LGTM! But verify the function usage in the codebase.

The addition of the consteval specifier to both functions is approved as it enhances compile-time evaluation.

However, ensure that all calls to deduce_disposable_strategy and deduce_updated_disposable_strategy are compatible with compile-time evaluation.

Run the following script to verify the function usage:

Also applies to: 94-94

Verification successful

Function Usage Verified for Compile-Time Evaluation

The usage of deduce_disposable_strategy and deduce_updated_disposable_strategy functions is compatible with compile-time evaluation. They are primarily used in type deduction contexts, which align with the consteval specifier. No runtime evaluation usages were found.

  • Files with relevant usage:
    • src/rpp/rpp/subjects/behavior_subject.hpp
    • src/rpp/rpp/subjects/publish_subject.hpp
    • src/rpp/rpp/subjects/replay_subject.hpp
    • src/rpp/rpp/sources/defer.hpp
    • src/rpp/rpp/sources/create.hpp
    • src/rpp/rpp/operators/details/forwarding_subject.hpp
    • src/rpp/rpp/observers/observer.hpp
    • src/rpp/rpp/observables/observable.hpp
    • src/rpp/rpp/observables/details/chain_strategy.hpp
    • src/rpp/rpp/observables/connectable_observable.hpp
    • src/rpp/rpp/observables/blocking_observable.hpp
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `deduce_disposable_strategy` and `deduce_updated_disposable_strategy` are compatible with compile-time evaluation.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type cpp -A 5 $'deduce_disposable_strategy'
rg --type cpp -A 5 $'deduce_updated_disposable_strategy'

Length of output: 11655

@github-actions

github-actions Bot commented Aug 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

BENCHMARK RESULTS (AUTOGENERATED)

ci-ubuntu-gcc

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 299.89 ns 2.16 ns 2.16 ns 1.00
Subscribe empty callbacks to empty observable via pipe operator 303.34 ns 2.16 ns 2.16 ns 1.00

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 702.23 ns 0.31 ns 0.31 ns 1.00
from array of 1 - create + subscribe + current_thread 1049.78 ns 3.71 ns 3.70 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 2229.13 ns 103.30 ns 103.64 ns 1.00
defer from array of 1 - defer + create + subscribe + immediate 740.60 ns 0.31 ns 0.31 ns 1.00
interval - interval + take(3) + subscribe + immediate 2128.28 ns 59.23 ns 59.19 ns 1.00
interval - interval + take(3) + subscribe + current_thread 3010.76 ns 32.42 ns 32.40 ns 1.00
from array of 1 - create + as_blocking + subscribe + new_thread 30023.64 ns 28376.95 ns 28241.49 ns 1.00
from array of 1000 - create + as_blocking + subscribe + new_thread 40494.78 ns 51732.33 ns 49638.82 ns 1.04
concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe 3563.04 ns 127.07 ns 126.06 ns 1.01

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 1081.14 ns 0.31 ns 0.31 ns 1.00
immediate_just+filter(true)+subscribe 845.98 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 1072.84 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 953.64 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+first()+subscribe 1228.62 ns 0.62 ns 0.62 ns 1.00
immediate_just(1,2)+last()+subscribe 907.18 ns 0.31 ns 0.31 ns 1.00
immediate_just+take_last(1)+subscribe 1137.42 ns 17.61 ns 17.28 ns 1.02
immediate_just(1,2,3)+element_at(1)+subscribe 869.16 ns 0.31 ns 0.31 ns 1.00

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 259.69 ns 2.16 ns 2.16 ns 1.00
current_thread scheduler create worker + schedule 367.62 ns 5.87 ns 5.88 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 837.47 ns 56.85 ns 56.64 ns 1.00

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 852.43 ns 0.31 ns 0.31 ns 1.00
immediate_just+scan(10, std::plus)+subscribe 898.06 ns 0.31 ns 0.31 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 2304.02 ns 166.97 ns 169.33 ns 0.99
immediate_just+buffer(2)+subscribe 1563.16 ns 13.91 ns 13.58 ns 1.02
immediate_just+window(2)+subscribe + subscsribe inner 2404.73 ns 1042.53 ns 1076.55 ns 0.97

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 839.06 ns - - 0.00
immediate_just+take_while(true)+subscribe 845.25 ns 0.31 ns 0.31 ns 1.00

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 2001.59 ns 0.31 ns 0.31 ns 1.00

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 3433.72 ns 186.02 ns 191.86 ns 0.97
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 3771.08 ns 172.81 ns 173.99 ns 0.99
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 147.36 ns 130.97 ns 1.13
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 3561.57 ns 986.43 ns 952.80 ns 1.04
immediate_just(1) + zip(immediate_just(2)) + subscribe 2145.13 ns 214.14 ns 208.77 ns 1.03

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 34.56 ns 14.72 ns 14.71 ns 1.00
subscribe 100 observers to publish_subject 201284.20 ns 15356.31 ns 15458.50 ns 0.99
100 on_next to 100 observers to publish_subject 27187.63 ns 17209.34 ns 20148.07 ns 0.85

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 1420.44 ns 12.66 ns 12.65 ns 1.00
basic sample with immediate scheduler 1443.08 ns 5.55 ns 5.55 ns 1.00

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 909.01 ns 0.31 ns 0.31 ns 1.00

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 2073.62 ns 990.27 ns 972.11 ns 1.02
create(on_error())+retry(1)+subscribe 624.88 ns 130.69 ns 113.79 ns 1.15

ci-macos

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 978.82 ns 3.98 ns 3.93 ns 1.01
Subscribe empty callbacks to empty observable via pipe operator 980.82 ns 3.96 ns 4.02 ns 0.98

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 1923.86 ns 0.23 ns 0.33 ns 0.71
from array of 1 - create + subscribe + current_thread 2436.00 ns 33.23 ns 33.76 ns 0.98
concat_as_source of just(1 immediate) create + subscribe 5748.42 ns 363.20 ns 335.53 ns 1.08
defer from array of 1 - defer + create + subscribe + immediate 2103.15 ns 0.25 ns 0.24 ns 1.04
interval - interval + take(3) + subscribe + immediate 5357.31 ns 121.71 ns 116.83 ns 1.04
interval - interval + take(3) + subscribe + current_thread 6341.72 ns 102.67 ns 101.10 ns 1.02
from array of 1 - create + as_blocking + subscribe + new_thread 87442.36 ns 84633.83 ns 91111.25 ns 0.93
from array of 1000 - create + as_blocking + subscribe + new_thread 104826.20 ns 97928.44 ns 89416.92 ns 1.10
concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe 8834.65 ns 409.75 ns 381.91 ns 1.07

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 3068.45 ns 0.25 ns 0.23 ns 1.05
immediate_just+filter(true)+subscribe 2276.65 ns 0.24 ns 0.23 ns 1.02
immediate_just(1,2)+skip(1)+subscribe 3054.99 ns 0.25 ns 0.23 ns 1.05
immediate_just(1,1,2)+distinct_until_changed()+subscribe 2363.16 ns 0.53 ns 0.47 ns 1.14
immediate_just(1,2)+first()+subscribe 3593.31 ns 0.26 ns 0.24 ns 1.10
immediate_just(1,2)+last()+subscribe 2489.51 ns 0.26 ns 0.23 ns 1.13
immediate_just+take_last(1)+subscribe 3094.26 ns 0.27 ns 0.23 ns 1.13
immediate_just(1,2,3)+element_at(1)+subscribe 2444.80 ns 0.27 ns 0.23 ns 1.14

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 949.12 ns 4.58 ns 4.60 ns 1.00
current_thread scheduler create worker + schedule 1333.71 ns 40.52 ns 37.69 ns 1.07
current_thread scheduler create worker + schedule + recursive schedule 2263.41 ns 230.05 ns 204.21 ns 1.13

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 2334.81 ns 4.64 ns 4.43 ns 1.05
immediate_just+scan(10, std::plus)+subscribe 2336.18 ns 0.47 ns 0.47 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 5292.99 ns 404.28 ns 403.54 ns 1.00
immediate_just+buffer(2)+subscribe 2523.81 ns 64.78 ns 65.24 ns 0.99
immediate_just+window(2)+subscribe + subscsribe inner 5510.20 ns 2404.50 ns 2368.96 ns 1.02

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 2376.22 ns - - 0.00
immediate_just+take_while(true)+subscribe 2436.26 ns 0.27 ns 0.24 ns 1.12

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 5760.24 ns 5.97 ns 4.90 ns 1.22

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 8175.69 ns 500.40 ns 439.64 ns 1.14
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 9019.90 ns 496.03 ns 439.79 ns 1.13
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 465.97 ns 460.60 ns 1.01
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 7993.08 ns 2017.26 ns 1908.17 ns 1.06
immediate_just(1) + zip(immediate_just(2)) + subscribe 5412.26 ns 843.15 ns 841.30 ns 1.00

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 87.05 ns 52.74 ns 48.76 ns 1.08
subscribe 100 observers to publish_subject 407349.00 ns 47001.83 ns 40940.92 ns 1.15
100 on_next to 100 observers to publish_subject 57583.90 ns 19286.54 ns 16792.09 ns 1.15

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 2929.42 ns 71.84 ns 67.97 ns 1.06
basic sample with immediate scheduler 2768.77 ns 19.55 ns 18.73 ns 1.04

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 2731.15 ns 0.27 ns 0.23 ns 1.17

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 7708.04 ns 4756.74 ns 4120.80 ns 1.15
create(on_error())+retry(1)+subscribe 2076.55 ns 350.98 ns 296.16 ns 1.19

ci-ubuntu-clang

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 268.95 ns 0.88 ns 0.88 ns 1.00
Subscribe empty callbacks to empty observable via pipe operator 278.93 ns 0.88 ns 0.88 ns 1.00

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 571.06 ns 0.39 ns 0.31 ns 1.27
from array of 1 - create + subscribe + current_thread 790.41 ns 4.32 ns 4.32 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 2368.88 ns 135.85 ns 136.00 ns 1.00
defer from array of 1 - defer + create + subscribe + immediate 768.77 ns 0.31 ns 0.31 ns 1.00
interval - interval + take(3) + subscribe + immediate 2215.85 ns 58.27 ns 58.31 ns 1.00
interval - interval + take(3) + subscribe + current_thread 3234.35 ns 30.92 ns 30.88 ns 1.00
from array of 1 - create + as_blocking + subscribe + new_thread 30405.53 ns 28601.67 ns 28329.14 ns 1.01
from array of 1000 - create + as_blocking + subscribe + new_thread 42072.25 ns 38875.53 ns 36705.10 ns 1.06
concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe 3656.31 ns 159.31 ns 161.48 ns 0.99

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 1152.66 ns 0.31 ns 0.31 ns 1.00
immediate_just+filter(true)+subscribe 845.89 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 1085.55 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 863.44 ns 0.62 ns 0.62 ns 1.00
immediate_just(1,2)+first()+subscribe 1372.50 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+last()+subscribe 998.69 ns 0.31 ns 0.31 ns 1.00
immediate_just+take_last(1)+subscribe 1201.53 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2,3)+element_at(1)+subscribe 861.26 ns 0.31 ns 0.31 ns 1.00

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 285.11 ns 0.88 ns 0.88 ns 1.00
current_thread scheduler create worker + schedule 395.16 ns 4.63 ns 4.63 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 865.06 ns 55.85 ns 55.95 ns 1.00

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 858.99 ns 0.31 ns 0.31 ns 1.00
immediate_just+scan(10, std::plus)+subscribe 967.12 ns 0.31 ns 0.31 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 2281.88 ns 139.20 ns 138.11 ns 1.01
immediate_just+buffer(2)+subscribe 1556.33 ns 13.89 ns 13.59 ns 1.02
immediate_just+window(2)+subscribe + subscsribe inner 2429.18 ns 924.65 ns 925.17 ns 1.00

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 851.75 ns - - 0.00
immediate_just+take_while(true)+subscribe 840.91 ns 0.31 ns 0.31 ns 1.00

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 2036.36 ns 0.31 ns 0.31 ns 1.00

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 3351.08 ns 160.72 ns 160.57 ns 1.00
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 3715.91 ns 146.19 ns 146.16 ns 1.00
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 144.37 ns 144.11 ns 1.00
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 3368.45 ns 853.73 ns 845.01 ns 1.01
immediate_just(1) + zip(immediate_just(2)) + subscribe 2213.51 ns 206.97 ns 203.72 ns 1.02

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 52.12 ns 17.55 ns 17.80 ns 0.99
subscribe 100 observers to publish_subject 211129.80 ns 15960.47 ns 15972.21 ns 1.00
100 on_next to 100 observers to publish_subject 37961.48 ns 17410.47 ns 20863.75 ns 0.83

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 1292.83 ns 11.72 ns 11.73 ns 1.00
basic sample with immediate scheduler 1321.05 ns 6.17 ns 6.17 ns 1.00

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 986.23 ns 0.31 ns 0.31 ns 1.00

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 2148.66 ns 1198.27 ns 1188.66 ns 1.01
create(on_error())+retry(1)+subscribe 662.03 ns 145.72 ns 146.83 ns 0.99

ci-windows

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 562.88 ns 4.32 ns 4.32 ns 1.00
Subscribe empty callbacks to empty observable via pipe operator 586.64 ns 4.32 ns 4.32 ns 1.00

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 1153.61 ns 4.63 ns 4.62 ns 1.00
from array of 1 - create + subscribe + current_thread 1423.71 ns 15.43 ns 15.43 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 3722.74 ns 172.68 ns 173.67 ns 0.99
defer from array of 1 - defer + create + subscribe + immediate 1196.26 ns 4.93 ns 4.93 ns 1.00
interval - interval + take(3) + subscribe + immediate 3241.14 ns 133.54 ns 133.46 ns 1.00
interval - interval + take(3) + subscribe + current_thread 3394.19 ns 54.71 ns 54.36 ns 1.01
from array of 1 - create + as_blocking + subscribe + new_thread 126000.00 ns 119670.00 ns 109877.78 ns 1.09
from array of 1000 - create + as_blocking + subscribe + new_thread 134075.00 ns 134362.50 ns 131385.71 ns 1.02
concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe 5522.27 ns 206.96 ns 208.31 ns 0.99

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 2149.00 ns 12.87 ns 12.87 ns 1.00
immediate_just+filter(true)+subscribe 1325.97 ns 11.71 ns 11.72 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 1747.10 ns 13.06 ns 13.04 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 1648.04 ns 15.81 ns 15.81 ns 1.00
immediate_just(1,2)+first()+subscribe 2076.99 ns 12.64 ns 12.63 ns 1.00
immediate_just(1,2)+last()+subscribe 2030.00 ns 14.09 ns 14.12 ns 1.00
immediate_just+take_last(1)+subscribe 2278.33 ns 60.93 ns 59.13 ns 1.03
immediate_just(1,2,3)+element_at(1)+subscribe 1361.10 ns 13.78 ns 13.78 ns 1.00

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 475.12 ns 6.18 ns 6.17 ns 1.00
current_thread scheduler create worker + schedule 655.77 ns 14.15 ns 14.15 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 1337.39 ns 102.97 ns 104.68 ns 0.98

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 1332.11 ns 11.24 ns 11.10 ns 1.01
immediate_just+scan(10, std::plus)+subscribe 1431.80 ns 21.29 ns 21.27 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 3462.50 ns 201.09 ns 210.03 ns 0.96
immediate_just+buffer(2)+subscribe 2638.82 ns 60.00 ns 57.82 ns 1.04
immediate_just+window(2)+subscribe + subscsribe inner 4018.90 ns 1289.56 ns 1339.68 ns 0.96

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 1638.52 ns 11.46 ns 11.46 ns 1.00
immediate_just+take_while(true)+subscribe 1340.13 ns 11.70 ns 11.70 ns 1.00

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 3158.99 ns 7.40 ns 7.40 ns 1.00

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 5111.11 ns 220.15 ns 229.58 ns 0.96
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 5595.24 ns 214.72 ns 217.69 ns 0.99
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 198.73 ns 202.87 ns 0.98
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 5432.00 ns 945.14 ns 945.44 ns 1.00
immediate_just(1) + zip(immediate_just(2)) + subscribe 3607.02 ns 535.56 ns 525.43 ns 1.02

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 37.50 ns 19.77 ns 19.76 ns 1.00
subscribe 100 observers to publish_subject 279675.00 ns 29607.32 ns 28109.76 ns 1.05
100 on_next to 100 observers to publish_subject 51970.00 ns 38729.63 ns 38703.85 ns 1.00

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 1916.31 ns 57.27 ns 57.91 ns 0.99
basic sample with immediate scheduler 2315.29 ns 38.59 ns 36.72 ns 1.05

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 1468.78 ns 19.97 ns 19.98 ns 1.00

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 2206.09 ns 332.10 ns 361.32 ns 0.92
create(on_error())+retry(1)+subscribe 1448.80 ns 145.66 ns 150.20 ns 0.97

coderabbitai[bot]
coderabbitai Bot reviewed Aug 21, 2024
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 91a3897 and 6b09e1d.

Files selected for processing (1)
  • cmake/coverage.cmake (1 hunks)
Additional comments not posted (4)
cmake/coverage.cmake (4)

8-9: Good use of centralizing coverage targets.

The introduction of RPP_COVERAGE_TARGETS improves maintainability and readability by consolidating multiple test targets for coverage reporting.

12-13: Enhanced coverage data merging.

Including additional input files for llvm-profdata merge ensures a more comprehensive coverage report. The output file name change to results.profdata reflects this broader scope.

14-14: Improved readability with centralized coverage targets.

Using the RPP_COVERAGE_TARGETS variable in the llvm-cov report command enhances readability and reduces redundancy.

15-15: Consistent use of centralized coverage targets.

The llvm-cov show command now uses the RPP_COVERAGE_TARGETS variable, improving readability and maintainability.

@codecov

codecov Bot commented Aug 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (c154676) to head (423b1d8).
Report is 1 commits behind head on v2.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v2     #621      +/-   ##
==========================================
- Coverage   94.92%   94.88%   -0.05%     
==========================================
  Files          94       97       +3     
  Lines        1734     1857     +123     
==========================================
+ Hits         1646     1762     +116     
- Misses         88       95       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexInLog AlexInLog merged commit 0ea16c2 into v2 Aug 22, 2024
@AlexInLog AlexInLog deleted the minor_coverage branch August 22, 2024 08:02
@sonarqubecloud

sonarqubecloud Bot commented Aug 22, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlexInLog